Skip to content

Use IO<File> as data source for memory editors #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolasnoble merged 6 commits into from
Apr 19, 2026

Ensure read-only behavior if no write callback provided.

a54c9e3
Select commit
Loading
Failed to load commit list.
Merged

Use IO<File> as data source for memory editors #2011

Ensure read-only behavior if no write callback provided.
a54c9e3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 19, 2026 in 0s

10.27% (+1.16%) compared to 4152915

View this Pull Request on Codecov

10.27% (+1.16%) compared to 4152915

Details

Codecov Report

❌ Patch coverage is 0% with 138 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.27%. Comparing base (4152915) to head (a54c9e3).
⚠️ Report is 89 commits behind head on main.

Files with missing lines Patch % Lines
src/gui/gui.cc 0.00% 45 Missing ⚠️
..._party/imgui_memory_editor/imgui_memory_editor.cpp 0.00% 37 Missing ⚠️
src/support/file.cc 0.00% 27 Missing ⚠️
...rd_party/imgui_memory_editor/imgui_memory_editor.h 0.00% 15 Missing ⚠️
src/gui/gui.h 0.00% 8 Missing ⚠️
src/support/file.h 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2011      +/-   ##
==========================================
+ Coverage    9.11%   10.27%   +1.16%     
==========================================
  Files         470      519      +49     
  Lines      147911   149850    +1939     
==========================================
+ Hits        13482    15397    +1915     
- Misses     134429   134453      +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov