Fix #108 side effect#131
Open
stephanebachelier wants to merge 3 commits intogruntjs:mainfrom
Open
Conversation
|
Cloned from comment in: #108 @stephanebachelier If you have a function that returns a dot based namespace, you will still have the issue. |
|
@stephanebachelier No updates? |
Contributor
Author
|
@lostthetrail sorry did not had the time before to complete my patch. Will push an update tomorrow. |
|
@stephanebachelier Any updates? |
a456586 to
c33c9f1
Compare
Contributor
Author
|
@lostthetrail I had issue to rebase my work on master. Are you using the filename variable like this: |
|
Not exactly your example. |
Contributor
Author
|
@lostthetrail thank for you answer, I will add a test with your example. |
|
@stephanebachelier Did this ever happen? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #108 (comment) about #108 being backward incompatible with AMD namespace with dots.