Fix to issue #510 Watch doesn't detect cascading changes when nospawn is true#512
Open
bchabrier wants to merge 6 commits intogruntjs:mainfrom
Open
Fix to issue #510 Watch doesn't detect cascading changes when nospawn is true#512bchabrier wants to merge 6 commits intogruntjs:mainfrom
bchabrier wants to merge 6 commits intogruntjs:mainfrom
Conversation
|
Is anybody going to merge this? |
|
Hello? |
|
Why is this still open? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #510, by keeping the watchers when the task is running (i.e. when
nospawnis used). Inspawnmode, the watchers are closed and recreated as before.I have added a test suite in
nospawn_test.js, which usesgrunt-contrib-copy. The test creates asource.jsfile, which is copied intodestination.js. Without the fix, the creation ofsource.jsis correctly detected by watch, not the creation ofdestination.js.The full test suite passes on travis, but erratically fails on windows (interrupt).
Hope that helps!