Skip to content

Commit

Permalink
fix: additional pod/deployment labeling bool string encapsulation (#184)
Browse files Browse the repository at this point in the history
  • Loading branch information
n-h-n authored Jan 24, 2024
1 parent 86820d6 commit c4a670c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions charts/k8s-service/templates/_deployment_spec.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ metadata:
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/managed-by: {{ .Release.Service }}
{{- range $key, $value := .Values.additionalDeploymentLabels }}
{{ $key }}: {{ $value }}
{{ $key }}: "{{ $value }}"
{{- end}}
{{- with .Values.deploymentAnnotations }}
annotations:
Expand Down Expand Up @@ -131,7 +131,7 @@ spec:
gruntwork.io/deployment-type: main
{{- end }}
{{- range $key, $value := .Values.additionalPodLabels }}
{{ $key }}: {{ $value }}
{{ $key }}: "{{ $value }}"
{{- end }}
{{- with .Values.podAnnotations }}
Expand Down
4 changes: 2 additions & 2 deletions charts/k8s-service/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -334,11 +334,11 @@ additionalDeploymentLabels: {}
# NOTE: This variable is injected directly into the pod spec.
podAnnotations: {}

# additionalDeploymentLabels will add the provided map to the labels for the Pods created by the deployment resource.
# additionalPodLabels will add the provided map to the labels for the Pods created by the deployment resource.
# this is in addition to the helm template related labels created by the chart
# The keys and values are free form, but subject to the limitations of Kubernetes labelling.
# The match labels for the deployment aren't affected by these additional labels
# NOTE: This variable is injected directly into the deployment spec.
# NOTE: This variable is injected directly into the pod spec.
additionalPodLabels: {}

# minPodsAvailable specifies the minimum number of pods that should be available at any given point in time. This is
Expand Down

0 comments on commit c4a670c

Please sign in to comment.