fix(config): prevent workflow.research reset during milestone transitions#962
Open
j2h4u wants to merge 1 commit intogsd-build:mainfrom
Open
fix(config): prevent workflow.research reset during milestone transitions#962j2h4u wants to merge 1 commit intogsd-build:mainfrom
j2h4u wants to merge 1 commit intogsd-build:mainfrom
Conversation
…ions Two bugs caused workflow.research to silently reset to false: 1. new-milestone.md unconditionally overwrote workflow.research via config-set after asking about research — coupling a per-milestone decision to a persistent user preference. Now the research question is per-invocation only; persistent config changes via /gsd:settings. 2. verify.cjs health repair (createConfig/resetConfig) used flat keys (research, plan_checker, verifier) instead of the canonical nested workflow object from config.cjs, also missing branch templates, nyquist_validation, and brave_search fields. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two fixes that prevent
workflow.researchfrom being silently reset tofalseduring milestone transitions:new-milestone.md — Stop persisting the per-milestone research decision to
config.json. The research question is now per-invocation only;workflow.researchis a persistent user preference changeable via/gsd:settings.verify.cjs — Health repair (
createConfig/resetConfig) now writes the correct nestedworkflow: { research, plan_check, verifier, nyquist_validation }structure matchingconfig-ensure-section, instead of flat keys with wrong names.Why
/gsd:new-milestonealways asked "Research the domain ecosystem?" and ranconfig-set workflow.research true/falseregardless of the existing config value. This silently overwrote the user's persistent preference, causing subsequent/gsd:plan-phasecalls to skip research without the user realizing it.Separately,
/gsd:health --repairwrote config with flat keys (research,plan_checker) instead of the canonical nestedworkflowobject (workflow.research,workflow.plan_check), missingnyquist_validation, branch templates, andbrave_search.User context: I've hit this repeatedly over the last few weeks across multiple milestone transitions in a real project. For a long time I assumed I was accidentally disabling research myself and kept re-enabling it manually — it felt like a mystery. Finally traced it through git history of a project's
.planning/config.jsonand confirmed the pattern: at least 2 out of ~10 milestone transitions silently resetworkflow.researchtofalse. The downstream impact is significant — phases get planned without codebase research, the planner guesses at code structure, and plans end up needing replans or heavy correction during execution.Testing
Checklist
Breaking Changes
None