Skip to content

fix(issue): Artifact verification retries can be preempted by stuck-loop detection before retry budget exhausts#6182

Open
jeremymcs wants to merge 2 commits into
mainfrom
issue/5944-artifact-verification-retries-can-be-pre-1778892813
Open

fix(issue): Artifact verification retries can be preempted by stuck-loop detection before retry budget exhausts#6182
jeremymcs wants to merge 2 commits into
mainfrom
issue/5944-artifact-verification-retries-can-be-pre-1778892813

Conversation

@jeremymcs
Copy link
Copy Markdown
Collaborator

Summary

  • Fixed artifact-retry stuck-preemption and retry-hash instability, then validated with focused auto-loop and retry-policy tests (98 passing).

Bugs Addressed

  • Stuck detection preempts active artifact verification retries
  • Duplicate-failure hashing changes across retries due attempt text

Verification

  • Completed in the repository worktree before push.

Related Issue

Repo

  • gsd-build/gsd-2

Branch

  • issue/5944-artifact-verification-retries-can-be-pre-1778892813

jeremymcs added 2 commits May 15, 2026 19:56
…ries

stuck detection now suppresses same-unit stuck classification while active artifact verification retries are within budget.
…mpt text

artifact retry failure context no longer embeds volatile attempt text, keeping duplicate-failure hashing stable across retries.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 16, 2026

Warning

Rate limit exceeded

@jeremymcs has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 33 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 922f8c74-1429-4d10-97f2-d7823adf4dae

📥 Commits

Reviewing files that changed from the base of the PR and between db89d64 and bcca838.

📒 Files selected for processing (5)
  • src/resources/extensions/gsd/auto-post-unit.ts
  • src/resources/extensions/gsd/auto/detect-stuck.ts
  • src/resources/extensions/gsd/auto/phases.ts
  • src/resources/extensions/gsd/tests/artifact-retry-cap.test.ts
  • src/resources/extensions/gsd/tests/auto-loop.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue/5944-artifact-verification-retries-can-be-pre-1778892813

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

🔴 PR Risk Report — CRITICAL

Files changed 5
Systems affected 1
Overall risk 🔴 CRITICAL

Affected Systems

Risk System
🔴 critical Auto Engine
File Breakdown
Risk File Systems
🔴 src/resources/extensions/gsd/auto-post-unit.ts Auto Engine
🔴 src/resources/extensions/gsd/auto/detect-stuck.ts Auto Engine
🔴 src/resources/extensions/gsd/auto/phases.ts Auto Engine
src/resources/extensions/gsd/tests/artifact-retry-cap.test.ts (unclassified)
src/resources/extensions/gsd/tests/auto-loop.test.ts (unclassified)

⚠️ 🔴 Critical risk — the following systems require verification before merge:

  • 🔴 Auto Engine: validate auto-mode trigger conditions and loop termination

⛔ This PR should not be merged without executing this follow-up prompt.

Ask your coding agent to verify before submitting:

Review this PR for risks in: Auto Engine. Verify:

1. validate auto-mode trigger conditions and loop termination

Before modifying any code, assess the scope of this fix:

- Identify the root cause, not just the reported symptom.
- Search the codebase for other call sites, similar patterns, or duplicated logic that may share the same bug.
- List affected tests, documentation, and any downstream consumers that depend on the current behavior.
- Flag any changes that extend beyond the immediate file or function.

Report findings first. Then propose a fix scoped to the actual root cause, and wait for confirmation before applying changes outside the originally reported location.

💡 Have a Codex subscription? Get an independent second opinion: codex review --adversarial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Artifact verification retries can be preempted by stuck-loop detection before retry budget exhausts

1 participant