fix(issue): bug(plan-slice): stuck loop in refining phase because handlePlanSlice never clears is_sketch

[jeremymcs]

Summary

• Moved sketch-flag clearing to immediately follow slice-plan persistence in handlePlanSlice and verified the refining-exit regression test passes.

Verification

• Completed in the repository worktree before push.

Related Issue

• Closes bug(plan-slice): stuck loop in refining phase because handlePlanSlice never clears is_sketch #5917
• #5917 bug(plan-slice): stuck loop in refining phase because handlePlanSlice never clears is_sketch

Repo

• gsd-build/gsd-2

Branch

• issue/5917-bug-plan-slice-stuck-loop-in-refining-ph-1778894304

Summary by CodeRabbit

• Bug Fixes

  • Deferred slices now transition to pending when replanned; status updates occur before the new plan is saved.
  • Clearing of the sketch flag now happens after the plan is persisted to ensure derived state updates correctly.

• Tests

  • Added a test confirming the sketch flag is cleared and the slice goal is stored immediately after handling.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: dabc9ea1-e92c-4ab9-adce-2401b237882b

📥 Commits

Reviewing files that changed from the base of the PR and between 9cad985 and 804f970.

📒 Files selected for processing (1)

• src/resources/extensions/gsd/tests/plan-slice.test.ts

---

📝 Walkthrough

Walkthrough

The PR modifies handlePlanSlice's DB transaction: deferred slices are transitioned to "pending" before persisting planning, and clearing the slice's is_sketch flag is moved to run after upsertSlicePlanning within the same transaction.

Changes

Deferred slice replanning and sketch flag clearing

Layer / File(s)	Summary
Deferred slice status and sketch flag update in replanning transaction src/resources/extensions/gsd/tools/plan-slice.ts, src/resources/extensions/gsd/tests/plan-slice.test.ts	Adds a guard that sets a deferred slice's status to "pending" inside the transaction before calling upsertSlicePlanning, moves setSliceSketchFlag(..., false) to run after the planning upsert, and adds a test assertion verifying the planned slice's goal is persisted immediately after the handler runs.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• gsd-build/gsd-2#5862: Modifies handlePlanSlice transaction logic and replanning behavior in the same handler file.
• gsd-build/gsd-2#5832: Also updates handlePlanSlice to clear the slice "sketch" flag within the transaction and reorders related writes.
• gsd-build/gsd-2#6058: Related edits to handlePlanSlice surrounding transaction-level behavior and artifact cleanup.

Poem

🐰 I hopped into the DB tonight,
A deferred slice bathed in moonlight—
I nudged its status, cleared the sketch,
Now the loop stops; no more fetch.
Hooray, the plan persisted right. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main bug fix: clearing the is_sketch flag in handlePlanSlice to prevent the infinite refining loop.
Linked Issues check	✅ Passed	The changes directly address issue #5917 by updating handlePlanSlice to clear is_sketch flag within the transaction after planning persistence.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing the is_sketch flag clearing issue described in issue #5917; no extraneous modifications detected.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch issue/5917-bug-plan-slice-stuck-loop-in-refining-ph-1778894304

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🟢 PR Risk Report — LOW

Files changed	2
Systems affected	0
Overall risk	🟢 LOW