ChaosMod/Mp3Manager: Properly construct wide str when unloading sounds

Hot take: UB is bad
gta-chaos-mod · Feb 8, 2024 · a8e21fb · a8e21fb
1 parent 09c2992
commit a8e21fb
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/ChaosMod/Components/Mp3Manager.cpp b/ChaosMod/Components/Mp3Manager.cpp
@@ -13,9 +13,12 @@ Mp3Manager::~Mp3Manager()
 	{
 		for (const auto &soundFilePath : soundFileNames)
 		{
-			std::ostringstream oss;
-			oss << "close \"" << soundFilePath << "\"";
-			mciSendString(reinterpret_cast<LPCWSTR>(oss.str().c_str()), NULL, 0, NULL);
+			std::ostringstream tmp;
+			std::string tmpStr;
+			tmp << "close \"" << soundFilePath << "\"";
+			tmpStr               = tmp.str();
+			std::wstring wTmpStr = { tmpStr.begin(), tmpStr.end() };
+			mciSendString(wTmpStr.c_str(), NULL, 0, NULL);
 		}
 	}