Improvements to "Spawn Companion" effects #3703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Regynate
commented
Jan 27, 2025
Regynate
commented
- Extracted common code to set relationships
- Made spawned peds like / hate the same entities player does
- Extracted common code to set relationships - Made spawned peds like / hate the same entities player does
pongo1231
requested changes
Jan 27, 2025
ChaosMod/Util/Peds.h
Outdated
| @@ -55,3 +55,24 @@ inline Ped CreateHostilePed(Hash modelHash, Hash weaponHash, Vector3 *location = | |||
| SET_PED_FIRING_PATTERN(ped, 0xC6EE6B4C); | |||
| return ped; | |||
| } | |||
|
|
|||
| inline void SetCompanionRelationship(Ped ped, const char* name) | |||
There was a problem hiding this comment.
Considering we expose it to the Lua runtime we should accept a const std::string& instead
There was a problem hiding this comment.
Noted, didn't know that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.