This repository has been archived by the owner on Apr 10, 2024. It is now read-only.
feat: extend image.metadefs schemas #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
gtema
commented
Mar 14, 2024
gtema
commented
- fix(openapi): fix path parameter naming misuse
- feat: add ability to pass multiple api-ref docs
- feat: cover image.metadef schemas
when global path parameter name is constructed out of not parameter path
elements present before the parameter itself we get /volumes/{volume_id} =>
volumes_volume_id. But for paths longer then that it causes parameters to be
overriden volumes/{volume_id}/metadata/{id} is still volumes_volume_id
and that leads to parameter description eventually showing something
different. Instead construct global path parameter name as all non-param
elements + param_name itself (volumes_metadata_volume_id)
Some services have few api-ref docs that need to be processed. Convert param into the list and iterate over it
This is a relatively big change since metadefs themselves are not trivial. - rework response_key handling - rework subtypes conflict resolution - add new cli command type "list_from_struct" which allows building a "list" command for API that return object (it does not seem reasonable to alter data in SDK for that since it forces some assumptions about the data) - de-duplicate "domain" schema in identity.auth.token to make use of new subtype naming
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.