Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump async-tls from 0.12.0 to 0.13.0 #1294

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 22, 2024

Bumps async-tls from 0.12.0 to 0.13.0.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Jan 22, 2024
@dependabot dependabot bot force-pushed the dependabot/cargo/async-tls-0.13.0 branch from 05a608f to cf57d13 Compare January 26, 2024 09:02
@sdroege
Copy link
Member

sdroege commented Jan 31, 2024

Looks like async-tls 0.13 is broken:

error[E0446]: crate-private type `Conn<'a>` in public interface
  --> /github/home/.cargo/registry/src/index.crates.io-6f17d22bba15001f/async-tls-0.13.0/src/rusttls/stream.rs:13:5
   |
13 |     pub conn: Conn<'a>,
   |     ^^^^^^^^^^^^^^^^^^ can't leak crate-private type
...
17 | pub(crate) enum Conn<'a> {
   | ------------------------ `Conn<'a>` declared as crate-private

@sdroege
Copy link
Member

sdroege commented Jan 31, 2024

async-rs/async-tls#56

@dependabot dependabot bot force-pushed the dependabot/cargo/async-tls-0.13.0 branch 2 times, most recently from 220f6e9 to 2e28bc8 Compare February 4, 2024 07:48
@dependabot dependabot bot force-pushed the dependabot/cargo/async-tls-0.13.0 branch from 2e28bc8 to 2e78d02 Compare February 16, 2024 12:45
@bilelmoussaoui
Copy link
Member

@dependabot rebase

Bumps [async-tls](https://github.com/async-std/async-tls) from 0.12.0 to 0.13.0.
- [Release notes](https://github.com/async-std/async-tls/releases)
- [Commits](async-rs/async-tls@v0.12.0...v0.13.0)

---
updated-dependencies:
- dependency-name: async-tls
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/async-tls-0.13.0 branch from 2e78d02 to da4de49 Compare November 19, 2024 07:32
@bilelmoussaoui
Copy link
Member

merging, the breakage only affects a specific rust version, for an example only.

@bilelmoussaoui bilelmoussaoui merged commit 8044406 into main Nov 19, 2024
48 checks passed
@dependabot dependabot bot deleted the dependabot/cargo/async-tls-0.13.0 branch November 19, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants