Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify reading file contents to a String #1719

Merged
merged 1 commit into from
May 31, 2024

Conversation

mjgarton
Copy link
Contributor

This uses a simpler approach to reading the file contents to a String, making the code slightly more readable by removing code unrelated to the point of the example.

This uses a simpler approach to reading the file contents to a String,
making the code slightly more readable by removing code unrelated to the
point of the example.
Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would've just use std::fs and then fs::read_to_string() to make it clearer where the function comes from but either way is fine.

This was indeed unnecessarily convoluted :)

@bilelmoussaoui
Copy link
Member

let us land this as is, feel free to submit future improvements as separate PRs

@bilelmoussaoui bilelmoussaoui merged commit f1365cd into gtk-rs:master May 31, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants