Fix SqueezerBin::size_allocate()
in example
#1760
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example
squeezer_bin
is not working on my machine, as described in #1757.While investigating that bug, I noticed a mistake in
SqueezerBin::size_allocate()
. I noticed the functionchild_size()
is returning all zeros, because it is being passed the wrong argument. This PR fixes that mistake.There is still a bug in the code that causes this example to panic. To avoid panic and to test this change, comment out these lines:
gtk4-rs/examples/squeezer_bin/main.rs
Lines 22 to 24 in 3826b9a
cd
into the directoryexamples
and runcargo run --bin squeezer_bin
.After this change, the text "Hello World!" should be visible in the window.