Skip to content

Conversation

helio-frota
Copy link
Collaborator

@helio-frota helio-frota commented Oct 8, 2025

Summary by Sourcery

Enhancements:

  • Unify duplicate match arms for Sha256, Sha384, and Sha512 into one combined pattern branch

@helio-frota helio-frota requested a review from ctron October 8, 2025 09:55
Copy link
Contributor

sourcery-ai bot commented Oct 8, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR consolidates three identical match arms in the Id::value() method into a single arm using an OR pattern, simplifying and clarifying the code.

File-Level Changes

Change Details Files
Combined identical match arms into one using an OR pattern
  • Replaced separate Id::Sha256, Id::Sha384, Id::Sha512 arms with a single `Id::Sha256(inner)
Id::Sha384(inner)

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@helio-frota helio-frota added the backport release/0.4.z Backport (0.4.z) label Oct 8, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 68.17%. Comparing base (e710813) to head (1be1f35).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
common/src/id.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2017      +/-   ##
==========================================
- Coverage   68.43%   68.17%   -0.26%     
==========================================
  Files         359      359              
  Lines       19923    19921       -2     
  Branches    19923    19921       -2     
==========================================
- Hits        13634    13582      -52     
- Misses       5504     5558      +54     
+ Partials      785      781       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@helio-frota helio-frota removed the backport release/0.4.z Backport (0.4.z) label Oct 10, 2025
@helio-frota
Copy link
Collaborator Author

I was experimenting with clippy lints and sent this pull request on impulse, I'm going to close it to avoid noise

@helio-frota helio-frota deleted the redundant-match-arm-body branch October 10, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant