-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generating *.meta.js during production build #6
Conversation
Hi @guansss, Thanks for your time! |
Hi, sorry for the late response! And thank you for this PR, this is a great feature to have! I wonder why the meta file goes to Using Having a flag would be nice. I imagine something like |
Thanks for the review! Certainly, regex is the most robust way to perform the For the For the flag, I was thinking something like In the next few days, I will update the PR with the modifications. |
Thanks for the update! In my opinion, the word "generate" fits well, but as an option, it may be a bit too broad and could represent the entire process of converting the original meta.js to the meta comment block (both in *.user.js and *.meta.js). I think at least the word "file" should be included to indicate that we are going to generate an extra file. Maybe |
Changed to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This draft PR want to add the feature of the automatic generation of the
*.meta.js files
. I'm looking for a feedback or a confirmation if this is the appropriate direction.I'm don't really like the idea to user the
replace
function to generate the meta filenames, but is the most efficient way that I found since I prefer to avoid to generate twice the metaBlock. Any other ideas ?In your opinion, we should introduce a flag to enable or disable the generation of these meta files?
Thank you for your feedback!