Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update browser-extension-url-match dependency #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Giglium
Copy link
Contributor

@Giglium Giglium commented Nov 26, 2024

@guansss
Copy link
Owner

guansss commented Nov 29, 2024

Thanks for the PR!

Let's ignore the CI error and I'l deal with it later.

The test doesn't seem to cover this change, because port matching only happens in browser. We need to let the script actually run in browser, just like how this test does (no need for the "hot" part though):

const { hotReload, origin } = await devServerHot(monkey(withMiniCssExtract(config)))
await installDevScript(origin)
await page.goto(origin + STRICT_CSP_PAGE)

- Closes guansss#4
- Add test case to unsure compatibility with future releases
@Giglium
Copy link
Contributor Author

Giglium commented Dec 2, 2024

Thanks. Now I understand the error better, it isn't a compilation error. I've added the test case with the run on the browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"match" in meta file didn't support port
2 participants