Conversation
🦋 Changeset detectedLatest commit: 2a75b9f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days |
akash1810
force-pushed
the
aa/rm-wazuh
branch
from
050bcda to
4dd166d
Compare
jorgeazevedo
left a comment
jorgeazevedo
left a comment
There was a problem hiding this comment.
This looks good to me! Is there any requirements in terms of testing that we need to do to ship this kind of change?
|
This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days |
|
This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days |
akash1810
force-pushed
the
aa/rm-wazuh
branch
2 times, most recently
from
8fd2d2e to
d0f760c
Compare
Remove the `GuWazuhAccess` class which adds a security group of logical ID `WazuhSecurityGroup` to any stack using `GuAutoScalingGroup` either directly or via a pattern.
I've successfully tested these changes on guardian/cdk-playground. I think this, plus the unit tests, are enough? WDYT? |
|
See #2647 for more detailed upgrade docs. |
2 participants
What does this change?
Remove the
GuWazuhAccessclass which adds a security group of logical IDWazuhSecurityGroupto any stack usingGuAutoScalingGroupeither directly or via a pattern. This follows guardian/amigo#1601 which removed Wazuh from AMIgo.How to test
How can we measure success?
Closing of unused ports.
Have we considered potential risks?
N/A.
Checklist
Footnotes
Consider whether this is something that will mean changes to projects that have already been migrated, or to the CDK CLI tool. If changes are required, consider adding a checklist here and/or linking to related PRs. ↩
If you are adding a new construct or pattern, has new documentation been added? If you are amending defaults or changing behaviour, are the existing docs still valid? ↩