Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up typography CSS output #1068

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Conversation

jamesmockett
Copy link
Contributor

What are you changing?

  • Strips out comment from typography CSS and places semicolons in correct place so they're not rendered if the corresponding property has no value and is not output
  • Adds custom Jest matcher to normalise CSS with Lightning CSS and match the result

Why?

  • Our snapshot tests are more verbose than they need to be due to the unnecessary output from the typography API
  • By normalising the expected and received CSS with a custom matcher we don't need to worry about formatting and whitespace in the tests and can concentrate on the correct properties and values being present

@jamesmockett jamesmockett requested a review from a team as a code owner January 8, 2024 17:31
Copy link

changeset-bot bot commented Jan 8, 2024

⚠️ No Changeset found

Latest commit: cb61d9e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Jan 8, 2024
@jamesmockett jamesmockett linked an issue Jan 8, 2024 that may be closed by this pull request
@jamesmockett jamesmockett force-pushed the jm/clean-typography-output branch from 90c533b to cb61d9e Compare January 9, 2024 09:44
@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label Jan 9, 2024
@jamesmockett jamesmockett merged commit 1ece7c7 into main Jan 9, 2024
25 checks passed
@jamesmockett jamesmockett deleted the jm/clean-typography-output branch January 9, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up typography API output
2 participants