Add typography presets to Storybook#1272
Merged
jamesmockett merged 19 commits intojm/type-preset-release-branchfrom Mar 14, 2024
Merged
Add typography presets to Storybook#1272jamesmockett merged 19 commits intojm/type-preset-release-branchfrom
jamesmockett merged 19 commits intojm/type-preset-release-branchfrom
Conversation
|
Contributor
|
Tip Once this PR is ready to go, add the This saves us a lot of money by not running the tests before we need them. |
## What are you changing? - Adds built script to generate CSS for new [web typography presets](https://theguardian.design/2a1e5182b/p/01555f-typography-presets/b/830670) from the existing definitions in the design tokens package and export these as individual variables from Source Foundations - Updates some incorrect font sizes in the design tokens ```bash pnpm nx run @guardian/source-foundations:build-type-presets ``` ```json "textSansBold15": { "$value": { "fontFamily": "{typography.fontFamily.textSans}", "fontSize": "{typography.fontSize.15}", "lineHeight": "{typography.lineHeight.regular}", "fontWeight": "{typography.fontWeight.bold}", "fontStyle": "normal" } }, ``` ⬇️ ```tsx export const textSansBold15 = ` font-family: GuardianTextSans, "Guardian Text Sans Web", "Helvetica Neue", Helvetica, Arial, "Lucida Grande", sans-serif; font-size: 0.9375rem; line-height: 1.3; font-weight: 700; font-style: normal; `; ```
jamesmockett
force-pushed
the
jm/storybook-type-presets
branch
from
3d6e725 to
c64629d
Compare
jamesmockett
force-pushed
the
jm/type-preset-release-branch
branch
from
cc58a40 to
bb8c344
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you changing?