Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to storybook v8.0.5 #1318

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Upgrade to storybook v8.0.5 #1318

merged 1 commit into from
Apr 2, 2024

Conversation

SiAdcock
Copy link
Contributor

@SiAdcock SiAdcock commented Mar 28, 2024 •
edited
Loading

What are you changing?

Why?

I naively thought an upgrade might fix the accessibility scan issue. Alas it did not. However I took the opportunity to remove a deprecated package whilst I was here, which was causing version matching issues.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 69ae495

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Mar 28, 2024
SiAdcock
SiAdcock commented Mar 28, 2024
View reviewed changes
package.json Show resolved Hide resolved
SiAdcock
SiAdcock commented Mar 28, 2024
View reviewed changes
package.json Show resolved Hide resolved
@SiAdcock SiAdcock force-pushed the sa-upgrade-storybook branch 2 times, most recently from aca8589 to aac1bbe Compare March 28, 2024 22:38
@SiAdcock SiAdcock marked this pull request as ready for review March 28, 2024 22:41
@SiAdcock SiAdcock requested review from a team as code owners March 28, 2024 22:41
@SiAdcock SiAdcock self-assigned this Mar 28, 2024
@SiAdcock SiAdcock mentioned this pull request Mar 28, 2024
Open
3 tasks
@jamesmockett jamesmockett force-pushed the sa-upgrade-storybook branch from aac1bbe to 69ae495 Compare April 2, 2024 13:54
@jamesmockett jamesmockett added the run_chromatic Runs chromatic when label is applied label Apr 2, 2024
jamesmockett
jamesmockett approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@jamesmockett jamesmockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shame it didn't fix the contrast check issue, but good to replace the deprecated addons package 👍

@jamesmockett jamesmockett merged commit b33fa79 into main Apr 2, 2024
22 checks passed
@jamesmockett jamesmockett deleted the sa-upgrade-storybook branch April 2, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmockett jamesmockett jamesmockett approved these changes

Assignees

@SiAdcock SiAdcock

Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SiAdcock @jamesmockett