Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tools/scripts/** to scripts #1669

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Move tools/scripts/** to scripts #1669

merged 2 commits into from
Aug 28, 2024

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Aug 28, 2024

What are you changing?

have one scripts dir, instead of tools/scripts and scripts. also make scripts a package in its own right so we can push the deps out of the root

Why?

spotted in #1668 that we don't lint scripts, this makes it more standalone and ready to be linted

@sndrs sndrs requested a review from a team as a code owner August 28, 2024 13:57
Copy link

changeset-bot bot commented Aug 28, 2024

⚠️ No Changeset found

Latest commit: 008129c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sndrs sndrs self-assigned this Aug 28, 2024
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label Aug 28, 2024
Copy link
Contributor

@oliverabrahams oliverabrahams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@sndrs sndrs merged commit 3d65b88 into main Aug 28, 2024
19 checks passed
@sndrs sndrs deleted the sndrs/one-scripts branch August 28, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_chromatic Runs chromatic when label is applied 🛠 workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants