Skip to content

Make all storybook configs TS#1671

Merged
sndrs merged 6 commits intomainfrom
sndrs/storybook-configs-rationalise
Aug 29, 2024
Merged

Make all storybook configs TS#1671
sndrs merged 6 commits intomainfrom
sndrs/storybook-configs-rationalise

Conversation

@sndrs
Copy link
Copy Markdown
Member

@sndrs sndrs commented Aug 28, 2024

What are you changing?

  • make storybook configs all the same language

Why?

@sndrs sndrs requested review from a team as code owners August 28, 2024 16:14
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 28, 2024

⚠️ No Changeset found

Latest commit: 1f79323

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sndrs sndrs force-pushed the sndrs/storybook-configs-rationalise branch from 0ac47e3 to 021d886 Compare August 28, 2024 16:14
@github-actions
Copy link
Copy Markdown
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions Bot added the 📦 npm Affects a @guardian package on NPM label Aug 28, 2024
@sndrs sndrs self-assigned this Aug 28, 2024
@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label Aug 28, 2024
@sndrs sndrs enabled auto-merge (squash) August 28, 2024 16:34
@sndrs sndrs merged commit a4f49bb into main Aug 29, 2024
@sndrs sndrs deleted the sndrs/storybook-configs-rationalise branch August 29, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants