Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crossword inputs in all cells not just the current one #1891

Open
wants to merge 5 commits into
base: sndrs/grid-a11y
Choose a base branch
from
Open

Crossword inputs in all cells not just the current one #1891

wants to merge 5 commits into from
+177 −173

Conversation

oliverabrahams
Copy link
Contributor

@oliverabrahams oliverabrahams commented Jan 13, 2025 •
edited
Loading

What are you changing?

  • Make all the crossword cells inputs. This improves navigation of the screen reader as all the cells can be focused and have content all the time, not just when they are the current cell.
  • Handle focusing the correct cell using the ID rather than refs, now all of the cells have inputs we just need to find the correct one and focus it rather than updating the ref and then finding that ref.

Why?

  • Greatly improves screen reader navigation.
  • Uses the platform.

@oliverabrahams oliverabrahams requested a review from a team as a code owner January 13, 2025 10:11
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 65853a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Jan 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@oliverabrahams oliverabrahams changed the title make all the empty white cells have inputs. Uses the platform. Better… All the empty white cells have inputs Jan 13, 2025
@oliverabrahams oliverabrahams changed the title All the empty white cells have inputs Crossword inputs in all cells not just the current one Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
📦 npm Affects a @guardian package on NPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oliverabrahams