Skip to content

Fix for stored state. #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 24, 2025
Merged

Fix for stored state. #1894

merged 6 commits into from
Jan 24, 2025

Conversation

oliverabrahams
Copy link
Contributor

If the state received is invalid then set the state to be the default state and return the default state.

  • Currently it is returning the default state provided as the state but not resetting the state to the default value.

@oliverabrahams
Fix for stored state. If the state received is invalid then set the s…
2932aaf 
…tate to be the default state and return the default state
@oliverabrahams oliverabrahams requested a review from a team as a code owner January 15, 2025 16:28
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: a9e80e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Jan 15, 2025
@oliverabrahams oliverabrahams added the run_chromatic Runs chromatic when label is applied label Jan 22, 2025
@oliverabrahams oliverabrahams merged commit b6065a5 into main Jan 24, 2025
21 checks passed
@oliverabrahams oliverabrahams deleted the oa/fix-use-stored-state branch January 24, 2025 11:21
oliverabrahams added a commit that referenced this pull request Jan 27, 2025
@oliverabrahams
Revert "Fix for stored state. (#1894)"
01b07a0 
This reverts commit b6065a5.
@oliverabrahams oliverabrahams mentioned this pull request Jan 27, 2025
Merged
oliverabrahams added a commit that referenced this pull request Jan 27, 2025
@oliverabrahams
Revert "Fix for stored state. " (#1911)
e329d0c 
Revert "Fix for stored state.  (#1894)"

This seems to cause an issue with hydration on the client

This reverts commit b6065a5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arelra arelra arelra approved these changes

Assignees
No one assigned
Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
Decommission Frontend Rendering
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverabrahams @arelra