-
Notifications
You must be signed in to change notification settings - Fork 30
Use subtitles file and use in looping video #14624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
50fc17a
Use subtitles file and use in looping video
domlander 1e41d08
WIP - Trying to change the line cues are rendered on
domlander f179dee
Update hardcoded assets for testing m3u8, mp4 and vtt. This needs to …
abeddow91 e498c40
Remove background colour as this does not affect the existing cue box…
abeddow91 49dad50
Require CORS without credentials using "anonymous". This ensure the s…
abeddow91 94205ba
Measure the height of the video and set the absolute positioning of t…
abeddow91 1681b7b
Remove background colour palette for subtitles as the background colo…
abeddow91 d6e2c9a
Remove hardcoded testing properties
abeddow91 83d75d3
Reduce space from bottom to 12px on browser cues
abeddow91 a94431e
Alias vidRef.current to video for easier parsing
abeddow91 e58731e
Remove height protection as we should always be able to retrieve getB…
abeddow91 3e64bc9
Add comment to support future development of the loop video player
abeddow91 1c2d088
Merge branch 'main' into doml/subtitles
abeddow91 1d9b9ff
Merge branch 'main' into doml/subtitles
abeddow91 960530c
Merge branch 'main' into doml/subtitles
abeddow91 6c67bc0
Temporarily remove looping video stories to unblock PR.
abeddow91 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.