Self styled subtitles #14689
Draft
Self styled subtitles #14689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be removed before merge
… drawn by the browser. It instead draws another box around the cue box which is not desired.
…ubtitles are available to JS on all browsers.
…he cues by % off of that.
…ur cannot currently be modified whilst we only support the browser subtitle implementation.
…track of the current cue. This is exposed by the hook for rendering in an overlay
abeddow91
force-pushed
the
doml/subtitles
branch
2 times, most recently
from
a4b507b to
d6e2c9a
Compare
abeddow91
force-pushed
the
ab/self-styled-subtitles
branch
5 times, most recently
from
37d2e8a to
3ff9328
Compare
abeddow91
force-pushed
the
ab/self-styled-subtitles
branch
from
3ff9328 to
c054d15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Why?
Screenshots