Skip to content

guardian/eslint-config-typescript v12 #14747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2025
Merged

guardian/eslint-config-typescript v12 #14747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f084a3
`guardian/eslint-config-typescript` v12
JamieB-gu Oct 9, 2025
4e4344d
Merge branch 'main' into guardian-eslint-config-typescript-v12
JamieB-gu Oct 27, 2025
e8f43cf
Merge branch 'main' into guardian-eslint-config-typescript-v12
JamieB-gu Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions apps-rendering/config/.eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ module.exports = {
{
files: ['**/*.tsx'],
rules: {
'@typescript-eslint/ban-types': [
'@typescript-eslint/no-restricted-types': [
'error',
{
types: {
Expand All @@ -132,7 +132,6 @@ module.exports = {
'React.FC':
'Please use const MyThing = ({foo, bar}: Props) instead',
},
extendDefaults: true,
},
],
},
Expand Down
4 changes: 2 additions & 2 deletions apps-rendering/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"@guardian/cdk": "62.0.1",
"@guardian/content-api-models": "31.0.0",
"@guardian/content-atom-model": "6.1.0",
"@guardian/eslint-config-typescript": "11.0.0",
"@guardian/eslint-config-typescript": "12.0.0",
"@guardian/libs": "22.0.0",
"@guardian/renditions": "0.2.0",
"@guardian/source": "9.0.0",
Expand Down Expand Up @@ -75,7 +75,7 @@
"compression": "1.8.0",
"constructs": "10.4.2",
"core-js": "3.33.3",
"eslint": "8.56.0",
"eslint": "8.57.1",
"eslint-plugin-jsx-a11y": "6.7.1",
"eslint-plugin-react": "7.33.2",
"express": "5.1.0",
Expand Down
2 changes: 2 additions & 0 deletions apps-rendering/src/server/decoders.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ const decodeContent =

return decoder.read(protocol);
} else {
/* eslint-disable-next-line @typescript-eslint/prefer-promise-reject-errors --
* Part of an upgrade to get this rule enabled. */
return Promise.reject('Invalid request');
}
};
Expand Down
7 changes: 3 additions & 4 deletions dotcom-rendering/.eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ module.exports = {
files: ['**/**.js'],
rules: {
'global-require': 'off',
'@typescript-eslint/no-var-requires': 'off',
'@typescript-eslint/no-require-imports': 'off',
'@typescript-eslint/no-unsafe-member-access': 'off',
'@typescript-eslint/no-misused-promises': 'off',
},
Expand Down Expand Up @@ -245,7 +245,7 @@ module.exports = {
{
files: ['**/**.tsx'],
rules: {
'@typescript-eslint/ban-types': [
'@typescript-eslint/no-restricted-types': [
'warn',
{
types: {
Expand All @@ -259,7 +259,7 @@ module.exports = {
},
},
],
'@typescript-eslint/ban-types': [
'@typescript-eslint/no-restricted-types': [
'error',
{
types: {
Expand All @@ -274,7 +274,6 @@ module.exports = {
'React.FC':
'Please use const MyThing = ({foo, bar}: Props) instead',
},
extendDefaults: true,
},
],
},
Expand Down
4 changes: 2 additions & 2 deletions dotcom-rendering/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"@guardian/cdk": "62.0.1",
"@guardian/commercial-core": "29.0.0",
"@guardian/core-web-vitals": "7.0.0",
"@guardian/eslint-config-typescript": "11.0.0",
"@guardian/eslint-config-typescript": "12.0.0",
"@guardian/identity-auth": "6.0.1",
"@guardian/identity-auth-frontend": "8.1.0",
"@guardian/libs": "26.0.1",
Expand Down Expand Up @@ -104,7 +104,7 @@
"curlyquotes": "1.5.5",
"dompurify": "3.2.4",
"dynamic-import-polyfill": "0.1.1",
"eslint": "8.56.0",
"eslint": "8.57.1",
"eslint-config-airbnb-base": "15.0.0",
"eslint-config-airbnb-typescript": "17.0.0",
"eslint-plugin-custom-elements": "0.0.8",
Expand Down
Loading
Loading