Log warning if a deprecated file is used #3110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SHession
approved these changes
Jan 19, 2021
prout-bot
added
Pending-on-auth
Pending-on-collections
Pending-on-cropper
Pending-on-image-loader
Pending-on-image-loader-projection
Pending-on-kahuna
Pending-on-leases
Pending-on-media-api
Pending-on-metadata-editor
Pending-on-usage
Seen-on-collections
Seen-on-kahuna
and removed
Pending-on-collections
Pending-on-kahuna
labels
|
Seen on collections, kahuna (merged by @sihil 10 minutes and 6 seconds ago) Please check your changes! |
|
Seen on auth, cropper, media-api, image-loader, image-loader-projection, metadata-editor (merged by @sihil 10 minutes and 37 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Instead of failing fast in #3043, this PR simply logs a warning when it encounters a legacy file.
How can success be measured?
This should go some way to helping us eventually deal with #3109.