Do not show invalid images as no_rights in costState #3902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did this in #3854 to try and override all other costs when an image is missing credit or description (one definition of "valid"). Instead it overrides all other costs whenever an image is uncroppable (restricted, overquota, etc., the other definition of "valid"). costState is used to determine both which flags to show on the search results page, and also the warnings/error messages on the image page, which means that this change hid the restriction text from ALL unpermissioned users! So revert this logic now, and commit to finding a better way of applying the invalid flag in the future.
prout-bot
added
Pending-on-auth
Pending-on-collections
Pending-on-cropper
Pending-on-image-loader
Pending-on-kahuna
Pending-on-leases
Pending-on-media-api
Pending-on-metadata-editor
Pending-on-thrall
Pending-on-usage
and removed
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
labels
|
Seen on auth, usage, collections, media-api, kahuna, image-loader, thrall, leases (merged by @andrew-nowak 8 minutes and 36 seconds ago) Please check your changes! |
prout-bot
added
Seen-on-auth
Seen-on-collections
Seen-on-image-loader
Seen-on-kahuna
Seen-on-leases
and removed
Pending-on-thrall
labels
prout-bot
added
Seen-on-media-api
Seen-on-thrall
Seen-on-usage
Seen-on-cropper
and removed
Pending-on-cropper
labels
|
Seen on cropper (merged by @andrew-nowak 8 minutes and 44 seconds ago) Please check your changes! |
|
Seen on metadata-editor (merged by @andrew-nowak 8 minutes and 48 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
I did this in #3854 to try and override all other costs when an image is
missing credit or description (one definition of "valid"). Instead it
overrides all other costs whenever an image is uncroppable (restricted,
overquota, etc., the other definition of "valid").
costState is used to determine both which flags to show on the search
results page, and also the warnings/error messages on the image page,
which means that this change hid the restriction text from ALL
unpermissioned users! So revert this logic now, and commit to finding a
better way of applying the invalid flag in the future.
How should a reviewer test this change?
Look at an image with restrictions while without the edit_metadata permission. Can you see the restriction text? If you view the image in the search results page, you will unfortunately see only a yellow "restricted" flag, rather than a more descriptive red "!" flag.