Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for 'patch' request in amend holiday stops cypress test #1230

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

andrewHEguardian
Copy link
Contributor

@andrewHEguardian andrewHEguardian commented Oct 20, 2023

What does this change?

Update the "can amend an existing holiday stop from overview page" Cypress test to click the "Confirm" button and mock the PATCH request. This is a followup from #1225 which fixed the component to actually check the correct variable to choose PATCH

How to test

Cypress tests pass in CI

How can we measure success?

Have we considered potential risks?

Images

Accessibility

Copy link
Contributor

@charleycampbell charleycampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update to the test 🚀

@andrewHEguardian andrewHEguardian merged commit 9249ab7 into main Oct 23, 2023
8 checks passed
@andrewHEguardian andrewHEguardian deleted the ahe/amend-holiday-stop-cypress branch October 23, 2023 08:25
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @andrewHEguardian 15 minutes and 5 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants