-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage Products design changes #1243
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adjusted the margins on the subHeading margin and removed border top - Added Manage in front of the product displayed WIP - Added in new section to display next payment date, next payment date and payment method . Need to format info on it properly - Remove the existing component which displays the above
…onent. Checked on mobile and buttons line up/centred uniformly
…in file re 'Term expected'
…s at the end of non link components as margins are different
…s at the end of non link components as margins are different
…g used on different journeys
margin between question and button as per the design
…ing separately meaning that everything lines up as it should!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Rob (Krentz) designed changes to the manage product screen as part of the designs for the new Digi Sub flow. This PR covers the changes to the manage product screen but for all products - the decision to do this refactor was mainly down to the shared components between products.
Summary of changes:
Designs can be found here
How to test
Check functionality on manage products
How can we measure success?
Have we considered potential risks?
Images
DigiSub Before
DigiSub After
DigiSub Mobile Before
DigiSub Mobile After
S+ Before
S+ After
S+ Mobile Before
S+ Mobile After
Newspaper Sub Before
Newspaper Sub After
Newspaper Sub Mobile Before
Newspaper Sub Mobile After
Accessibility