Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Products design changes #1243

Closed
wants to merge 17 commits into from

Conversation

charleycampbell
Copy link
Contributor

@charleycampbell charleycampbell commented Nov 8, 2023

What does this change?

Rob (Krentz) designed changes to the manage product screen as part of the designs for the new Digi Sub flow. This PR covers the changes to the manage product screen but for all products - the decision to do this refactor was mainly down to the shared components between products.

Summary of changes:

  • Upgrades to the spacing between the different components
  • Complete reworking of how user information is shown on the screen (which is inline with other changes made recently in MMA)
  • refactoring of which cancel method is shown and where it id displayed. Some products require the user to call our help centre and others are enabled to be cancelled via MMA. This means we have to show a different depending on the self cancellation flag.
  • refactored the buttons on the manage screen so they are all uniform when in mobile view

Designs can be found here

How to test

Check functionality on manage products

How can we measure success?

Have we considered potential risks?

Images

DigiSub Before
image
DigiSub After
image

DigiSub Mobile Before
image
DigiSub Mobile After
image

S+ Before
image
S+ After
image

S+ Mobile Before
image
S+ Mobile After
image
Newspaper Sub Before
image
Newspaper Sub After
image

Newspaper Sub Mobile Before
image
Newspaper Sub Mobile After
image

Accessibility

- Adjusted the margins on the subHeading margin and removed border top
- Added Manage in front of the product displayed

WIP
- Added in new section to display next payment date, next payment date and payment method . Need to format info on it properly
- Remove the existing component which displays the above
…onent. Checked on mobile and buttons line up/centred uniformly
…s at the end of non link components as margins are different
…s at the end of non link components as margins are different
margin between question and button as per the design
…ing separately meaning that everything lines up as it should!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant