Integrate with discount api #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix apply call
…-frontend into ahe/discount-api
andrewHEguardian
requested review from
rupertbates,
KentGrm and
charleycampbell
KentGrm
approved these changes
Dec 15, 2023
|
Seen on PROD (merged by @andrewHEguardian 12 minutes and 9 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Integrate with the new discount api to preview and apply discount within digisub saves journey.
Remove the hardcoded price data - instead use the API response for the discounted price and eligibility check. This means the code should work even if prices change.
How to test
Go to
/digital/?withFeature=digisubSaveand start cancellation journey. See discount offer, click to confirm discount and see next page.How can we measure success?
Have we considered potential risks?
Images
Accessibility