Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Fix the help centre sitemap by asserting the content type that it actually is in S3. Spotted because I was testing turning on eslint rule
'@typescript-eslint/prefer-nullish-coalescing'
How to test
Go to https://manage.theguardian.com/sitemap.txt, see content instead of
[]
as before this change.How can we measure success?
Have we considered potential risks?
Should we rather just change the content type of the file in S3 to
text/plain
(which seems to be more accurate?) - or fix whatever is creating that fileImages
Before
After
Accessibility