OAuth migration | Use new set username route #1311
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
As part of the OAuth migration, we've removed an old bug in IDAPI - being able to set your username more than once, if you happened to know the API endpoint to hit (because setting username just used
POST /user/me
). We've already introduced a new IDAPI endpoint,POST /user/me/username
, which only allows setting username once and only if it's not been set before. Once OAuth authorization to IDAPI is enabled in MMA, we will also be preventing the username being changed viaPOST /user/me
. This PR modifies the MMA frontend to use the new endpoint, and adds an E2E test for username updating.Dependencies
Tests