Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth migration | Use new set username route #1311

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

raphaelkabo
Copy link
Contributor

@raphaelkabo raphaelkabo commented Feb 7, 2024

What does this change?

As part of the OAuth migration, we've removed an old bug in IDAPI - being able to set your username more than once, if you happened to know the API endpoint to hit (because setting username just used POST /user/me). We've already introduced a new IDAPI endpoint, POST /user/me/username, which only allows setting username once and only if it's not been set before. Once OAuth authorization to IDAPI is enabled in MMA, we will also be preventing the username being changed via POST /user/me. This PR modifies the MMA frontend to use the new endpoint, and adds an E2E test for username updating.

Dependencies

Tests

  • Tested on CODE

@raphaelkabo raphaelkabo marked this pull request as ready for review February 8, 2024 10:28
Copy link
Contributor

@pvighi pvighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@raphaelkabo raphaelkabo merged commit 05dbf04 into main Feb 8, 2024
11 checks passed
@raphaelkabo raphaelkabo deleted the rk/new-set-username-route branch February 8, 2024 15:26
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @raphaelkabo 10 minutes and 39 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants