Make sure that the production build uses the current lockfile#1345
Merged
rupertbates merged 1 commit intomainfrom Jun 19, 2024
Merged
Make sure that the production build uses the current lockfile#1345rupertbates merged 1 commit intomainfrom
rupertbates merged 1 commit intomainfrom
Conversation
|
Seen on PROD (merged by @rupertbates 9 minutes and 34 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Up until now the final production build was being run with no lockfile. This meant that the versions of dependencies which end up being used in production can be different from those used during development.
This PR fixes that issue.
We actually found this because of an issue in the okta library, where a newer version of a dependency broke the library, this PR has more information: guardian/gateway#2775