Use user-benefits API to work out newspaper archive entitlement #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupertbates
changed the title
rBangay
reviewed
Dec 5, 2024
rBangay
approved these changes
Dec 5, 2024
|
Seen on PROD (merged by @rupertbates 10 minutes and 33 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Up until now we have been checking members-data-api to see whether a user is eligible for newspaper archive access. This was problematic because the only way we could deduce whether a user was entitled or not was if they had both the
supporterPlusandguardianWeeklySubscriberflag set, however this is not actually the same as being subscribed to tier three.This PR replaces the call to mdapi with a call to the new user-benefits API which has been built to centralise the logic around which users are entitled to which benefits.
Depends on this PR