path-to-regexp dependency vuln fix #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to a patched version
johnduffell
reviewed
Dec 16, 2024
| @@ -145,7 +145,7 @@ | |||
| "@emotion/react": "11.11.1", | |||
| "@guardian/ab-core": "2.0.0", | |||
| "@guardian/ab-react": "2.0.1", | |||
| "@guardian/commercial": "23.7.4", | |||
| "@guardian/commercial": "^23.7.5", | |||
There was a problem hiding this comment.
what does the extra ^ thing do?
There was a problem hiding this comment.
according to google it lets it automatically update the minor and patch version. But isn't that what package.json is supposed to prevent?
There was a problem hiding this comment.
if you don't use the caret then yes. If you have confidence that minor version bumps won't break anything then you can add the caret and let npm/yarn install the latest in the line of minor versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Bump relevant peer dependencies in order to bump the version of path-to-regexp that the project uses to a patched version.
Fixes the vulnerabilities reported by snyk and dependabot:
https://app.snyk.io/org/guardian-value/project/8acda083-6b55-431d-a2e0-a985b2349e78#issue-SNYK-JS-PATHTOREGEXP-8482416