Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update source dependencies #1433

Merged
merged 9 commits into from
Jan 8, 2025
Merged

Update source dependencies #1433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2df40a5
Bump source-devlopment-kitchen version up to 2.0.0 on the journey to …
Dec 17, 2024
3fa50bd
bump source-development-kitchen from v3 to v4
Dec 17, 2024
e7eb2b3
update source-development-kitchen to v5 and source to v6
Dec 17, 2024
ec38653
upgrade chromatic
Dec 18, 2024
a1ceb72
upgrade source-development-kitchen and source to version 7. Includes …
Dec 19, 2024
dc6f91a
bump source from v7 to v8
Dec 23, 2024
9e0b004
fix small css errors
Dec 23, 2024
17c503a
keep up to date with minor versions of guardian libs and guardian sou…
Dec 23, 2024
7cd57ac
update snapshot tests and remove unnecessary 'key' prop from mocked p…
Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions client/__tests__/__snapshots__/main.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ exports[`Main renders something 1`] = `
.emotion-1 {
color: #052962;
position: absolute;
text-align: center;
font-size: 12px;
textalign: center;
fontsize: 12px;
}

.emotion-1:focus {
Expand Down Expand Up @@ -111,7 +111,7 @@ exports[`Main renders something 1`] = `
}

.emotion-7 {
font-family: "GuardianTextEgyptian",Georgia,serif;
font-family: GuardianTextEgyptian,"Guardian Text Egyptian Web",Georgia,serif;
-webkit-box-flex: 1;
-webkit-flex-grow: 1;
-ms-flex-positive: 1;
Expand Down Expand Up @@ -268,10 +268,13 @@ exports[`Main renders something 1`] = `

.emotion-58 {
color: #FFE500;
font-family: GH Guardian Headline,"GuardianTextEgyptian",Georgia,serif;
font-size: 24px;
font-family: "GH Guardian Headline","Guardian Egyptian Web",Georgia,serif;
font-size: 1.5rem;
line-height: 1.15;
font-weight: 700;
font-style: normal;
--source-text-decoration-thickness: 3px;
line-height: 24px;
font-weight: bold;
margin-top: 3px;
margin-bottom: 12px;
}
Expand All @@ -294,9 +297,10 @@ exports[`Main renders something 1`] = `
display: -webkit-inline-flex;
display: -ms-inline-flexbox;
display: inline-flex;
-webkit-box-pack: justify;
-webkit-justify-content: space-between;
justify-content: space-between;
-webkit-box-pack: center;
-ms-flex-pack: center;
-webkit-justify-content: center;
justify-content: center;
-webkit-align-items: center;
-webkit-box-align: center;
-ms-flex-align: center;
Expand Down Expand Up @@ -833,7 +837,7 @@ html:not(.src-focus-disabled) .emotion-63 :focus {
>
<path
clipRule="evenodd"
d="M1 12.956h18.274l-7.167 8.575.932.932L23 12.478v-.956l-9.96-9.985-.932.932 7.166 8.575H1v1.912Z"
d="M1 12.956h18.274l-7.167 8.575.932.932L23 12.478v-.956l-9.96-9.985-.932.932 7.166 8.575H1z"
fillRule="evenodd"
/>
</svg>
Expand Down Expand Up @@ -864,7 +868,7 @@ html:not(.src-focus-disabled) .emotion-63 :focus {
>
<path
clipRule="evenodd"
d="M23 16.768 12.502 6.27h-1.004L1 16.768l.98.954L12 9.284l10.02 8.438.98-.954Z"
d="M23 16.768 12.502 6.27h-1.004L1 16.768l.98.954L12 9.284l10.02 8.438z"
fillRule="evenodd"
/>
</svg>
Expand Down
9 changes: 5 additions & 4 deletions client/__tests__/components/helpCentre/__snapshots__/helpCentreContactOptions.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,9 +1012,10 @@ exports[`HelpCentreContactOptions Help Centre landing page with live chat featur
display: -webkit-inline-flex;
display: -ms-inline-flexbox;
display: inline-flex;
-webkit-box-pack: justify;
-webkit-justify-content: space-between;
justify-content: space-between;
-webkit-box-pack: center;
-ms-flex-pack: center;
-webkit-justify-content: center;
justify-content: center;
-webkit-align-items: center;
-webkit-box-align: center;
-ms-flex-align: center;
Expand Down Expand Up @@ -1442,7 +1443,7 @@ html:not(.src-focus-disabled) .emotion-7:focus {
>
<path
clipRule="evenodd"
d="M1 12.956h18.274l-7.167 8.575.932.932L23 12.478v-.956l-9.96-9.985-.932.932 7.166 8.575H1v1.912Z"
d="M1 12.956h18.274l-7.167 8.575.932.932L23 12.478v-.956l-9.96-9.985-.932.932 7.166 8.575H1z"
fillRule="evenodd"
/>
</svg>
Expand Down
44 changes: 28 additions & 16 deletions client/__tests__/components/identity/__snapshots__/DropMenu.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,12 @@ exports[`DropMenu displays the text in the supplied color 1`] = `
}

.emotion-1 {
font-size: 17px;
font-family: "GuardianTextEgyptian",Georgia,serif;
font-weight: bold;
font-family: GuardianTextEgyptian,"Guardian Text Egyptian Web",Georgia,serif;
font-size: 1.0625rem;
line-height: 1.3;
font-weight: 700;
font-style: normal;
--source-text-decoration-thickness: 2px;
line-height: 24px;
text-transform: capitalize;
display: block;
Expand All @@ -39,7 +42,7 @@ exports[`DropMenu displays the text in the supplied color 1`] = `
margin-left: 4px;
}

.emotion-1.open:after {
.emotion-1.open:after: {
-webkit-transform: rotate(225deg);
-moz-transform: rotate(225deg);
-ms-transform: rotate(225deg);
Expand Down Expand Up @@ -78,9 +81,12 @@ exports[`DropMenu if closed, opens and shows children on click 1`] = `
}

.emotion-1 {
font-size: 17px;
font-family: "GuardianTextEgyptian",Georgia,serif;
font-weight: bold;
font-family: GuardianTextEgyptian,"Guardian Text Egyptian Web",Georgia,serif;
font-size: 1.0625rem;
line-height: 1.3;
font-weight: 700;
font-style: normal;
--source-text-decoration-thickness: 2px;
line-height: 24px;
text-transform: capitalize;
display: block;
Expand All @@ -107,7 +113,7 @@ exports[`DropMenu if closed, opens and shows children on click 1`] = `
margin-left: 4px;
}

.emotion-1.open:after {
.emotion-1.open:after: {
-webkit-transform: rotate(225deg);
-moz-transform: rotate(225deg);
-ms-transform: rotate(225deg);
Expand Down Expand Up @@ -150,9 +156,12 @@ exports[`DropMenu if open, closes and hides children on click 1`] = `
}

.emotion-1 {
font-size: 17px;
font-family: "GuardianTextEgyptian",Georgia,serif;
font-weight: bold;
font-family: GuardianTextEgyptian,"Guardian Text Egyptian Web",Georgia,serif;
font-size: 1.0625rem;
line-height: 1.3;
font-weight: 700;
font-style: normal;
--source-text-decoration-thickness: 2px;
line-height: 24px;
text-transform: capitalize;
display: block;
Expand All @@ -179,7 +188,7 @@ exports[`DropMenu if open, closes and hides children on click 1`] = `
margin-left: 4px;
}

.emotion-1.open:after {
.emotion-1.open:after: {
-webkit-transform: rotate(225deg);
-moz-transform: rotate(225deg);
-ms-transform: rotate(225deg);
Expand Down Expand Up @@ -218,9 +227,12 @@ exports[`DropMenu initalises in the unopened state and displays the title 1`] =
}

.emotion-1 {
font-size: 17px;
font-family: "GuardianTextEgyptian",Georgia,serif;
font-weight: bold;
font-family: GuardianTextEgyptian,"Guardian Text Egyptian Web",Georgia,serif;
font-size: 1.0625rem;
line-height: 1.3;
font-weight: 700;
font-style: normal;
--source-text-decoration-thickness: 2px;
line-height: 24px;
text-transform: capitalize;
display: block;
Expand All @@ -247,7 +259,7 @@ exports[`DropMenu initalises in the unopened state and displays the title 1`] =
margin-left: 4px;
}

.emotion-1.open:after {
.emotion-1.open:after: {
-webkit-transform: rotate(225deg);
-moz-transform: rotate(225deg);
-ms-transform: rotate(225deg);
Expand Down
102 changes: 32 additions & 70 deletions client/__tests__/components/identity/__snapshots__/NewsletterPreference.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,13 @@

exports[`NewsletterPreference component renders correctly and displays marketing information 1`] = `
.emotion-0 {
font-size: 14px;
font-family: "Guardian Text Sans Web","Helvetica Neue",Helvetica,Arial,"Lucida Grande",sans-serif;
line-height: 1.333;
font-family: GuardianTextSans,"Guardian Text Sans Web","Helvetica Neue",Helvetica,Arial,"Lucida Grande",sans-serif;
font-size: 0.875rem;
line-height: 1.3;
font-weight: 400;
font-style: normal;
--source-text-decoration-thickness: 2px;
lineheight: 1.333;
margin-top: 12px;
}

Expand All @@ -14,17 +18,12 @@ exports[`NewsletterPreference component renders correctly and displays marketing
display: -webkit-flex;
display: -ms-flexbox;
display: flex;
-webkit-align-items: center;
-webkit-box-align: center;
-ms-flex-align: center;
align-items: center;
min-height: 44px;
cursor: pointer;
-webkit-align-items: flex-start;
-webkit-box-align: flex-start;
-ms-flex-align: flex-start;
align-items: flex-start;
margin-bottom: 12px;
padding: 10px 0;
cursor: pointer;
}

.emotion-1:hover input {
Expand Down Expand Up @@ -118,7 +117,7 @@ html:not(.src-focus-disabled) .emotion-2:focus {
-moz-transform: rotate(45deg);
-ms-transform: rotate(45deg);
transform: rotate(45deg);
top: 14px;
top: 15px;
left: 9px;
pointer-events: none;
}
Expand Down Expand Up @@ -150,19 +149,6 @@ html:not(.src-focus-disabled) .emotion-2:focus {
}
}

@supports ((appearance: none) or (-webkit-appearance: none) or (-moz-appearance: none)) {
.emotion-3 {
top: 15px;
left: 9px;
}
}

@supports ((appearance: none) or (-webkit-appearance: none) or (-moz-appearance: none)) {
.emotion-3 {
top: 5px;
}
}

.emotion-4 {
cursor: pointer;
}
Expand All @@ -176,12 +162,6 @@ html:not(.src-focus-disabled) .emotion-2:focus {
--source-text-decoration-thickness: 2px;
color: #121212;
width: 100%;
font-family: GuardianTextSans,"Guardian Text Sans Web","Helvetica Neue",Helvetica,Arial,"Lucida Grande",sans-serif;
font-size: 1.0625rem;
line-height: 1.3;
font-weight: 400;
font-style: normal;
--source-text-decoration-thickness: 2px;
margin-top: 1px;
}

Expand All @@ -190,13 +170,14 @@ html:not(.src-focus-disabled) .emotion-2:focus {
}

.emotion-6 {
font-size: 14px;
font-family: "Guardian Text Sans Web","Helvetica Neue",Helvetica,Arial,"Lucida Grande",sans-serif;
font-family: GuardianTextSans,"Guardian Text Sans Web","Helvetica Neue",Helvetica,Arial,"Lucida Grande",sans-serif;
font-size: 0.875rem;
line-height: 1.3;
font-weight: 700;
font-style: normal;
--source-text-decoration-thickness: 2px;
cursor: pointer;
font-size: 14px;
line-height: 22px;
font-family: "Guardian Text Sans Web","Helvetica Neue",Helvetica,Arial,"Lucida Grande",sans-serif;
font-weight: bold;
margin: 0;
}

Expand Down Expand Up @@ -302,9 +283,13 @@ html:not(.src-focus-disabled) .emotion-2:focus {

exports[`NewsletterPreference component will select the checkbox when the selected prop is passed 1`] = `
.emotion-0 {
font-size: 14px;
font-family: "Guardian Text Sans Web","Helvetica Neue",Helvetica,Arial,"Lucida Grande",sans-serif;
line-height: 1.333;
font-family: GuardianTextSans,"Guardian Text Sans Web","Helvetica Neue",Helvetica,Arial,"Lucida Grande",sans-serif;
font-size: 0.875rem;
line-height: 1.3;
font-weight: 400;
font-style: normal;
--source-text-decoration-thickness: 2px;
lineheight: 1.333;
margin-top: 12px;
}

Expand All @@ -314,17 +299,12 @@ exports[`NewsletterPreference component will select the checkbox when the select
display: -webkit-flex;
display: -ms-flexbox;
display: flex;
-webkit-align-items: center;
-webkit-box-align: center;
-ms-flex-align: center;
align-items: center;
min-height: 44px;
cursor: pointer;
-webkit-align-items: flex-start;
-webkit-box-align: flex-start;
-ms-flex-align: flex-start;
align-items: flex-start;
margin-bottom: 12px;
padding: 10px 0;
cursor: pointer;
}

.emotion-1:hover input {
Expand Down Expand Up @@ -418,7 +398,7 @@ html:not(.src-focus-disabled) .emotion-2:focus {
-moz-transform: rotate(45deg);
-ms-transform: rotate(45deg);
transform: rotate(45deg);
top: 14px;
top: 15px;
left: 9px;
pointer-events: none;
}
Expand Down Expand Up @@ -450,19 +430,6 @@ html:not(.src-focus-disabled) .emotion-2:focus {
}
}

@supports ((appearance: none) or (-webkit-appearance: none) or (-moz-appearance: none)) {
.emotion-3 {
top: 15px;
left: 9px;
}
}

@supports ((appearance: none) or (-webkit-appearance: none) or (-moz-appearance: none)) {
.emotion-3 {
top: 5px;
}
}

.emotion-4 {
cursor: pointer;
}
Expand All @@ -476,12 +443,6 @@ html:not(.src-focus-disabled) .emotion-2:focus {
--source-text-decoration-thickness: 2px;
color: #121212;
width: 100%;
font-family: GuardianTextSans,"Guardian Text Sans Web","Helvetica Neue",Helvetica,Arial,"Lucida Grande",sans-serif;
font-size: 1.0625rem;
line-height: 1.3;
font-weight: 400;
font-style: normal;
--source-text-decoration-thickness: 2px;
margin-top: 1px;
}

Expand All @@ -490,13 +451,14 @@ html:not(.src-focus-disabled) .emotion-2:focus {
}

.emotion-6 {
font-size: 14px;
font-family: "Guardian Text Sans Web","Helvetica Neue",Helvetica,Arial,"Lucida Grande",sans-serif;
font-family: GuardianTextSans,"Guardian Text Sans Web","Helvetica Neue",Helvetica,Arial,"Lucida Grande",sans-serif;
font-size: 0.875rem;
line-height: 1.3;
font-weight: 700;
font-style: normal;
--source-text-decoration-thickness: 2px;
cursor: pointer;
font-size: 14px;
line-height: 22px;
font-family: "Guardian Text Sans Web","Helvetica Neue",Helvetica,Arial,"Lucida Grande",sans-serif;
font-weight: bold;
margin: 0;
}

Expand Down
2 changes: 1 addition & 1 deletion client/components/helpCentre/HelpCentrePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { css, Global } from '@emotion/react';
import { lazy, Suspense, useEffect, useState } from 'react';
import { BrowserRouter, Navigate, Route, Routes } from 'react-router-dom';
import { fonts } from '@/client/styles/fonts';
import { initFeatureSwitchUrlParamOverride } from '../../../shared/featureSwitches';
import { fonts } from '../../styles/fonts';
import { global } from '../../styles/global';
import { useAnalytics } from '../../utilities/hooks/useAnalytics';
import { useConsent } from '../../utilities/hooks/useConsent';
Expand Down
Loading
Loading