Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show singular cancelled subscription #1470

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

rBangay
Copy link
Contributor

@rBangay rBangay commented Feb 19, 2025

Context

You have only 1 product and it is cancelled and therefore returned in the /cancelled api response on the account overview.

Screenshot 2025-02-19 at 10 20 07

What does this PR change?

If you have only 1 product and it it cancelled then it should still show up in the account overview if it is returned in the '/cancelled' api response. Before if you didn't also have an active pruduct then it would render the empty account overview component

Images

Before After

…how up in the account overview if it it returned in the '/cancelled' spi response. Before if you didn't also have an active pruduct then it would render the empty account overview component
@rBangay rBangay requested a review from a team February 19, 2025 10:29
Copy link
Contributor

@MaelGNM MaelGNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rBangay rBangay merged commit 268cb4b into main Feb 19, 2025
13 checks passed
@rBangay rBangay deleted the show-singular-cancelled-product branch February 19, 2025 10:43
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @rBangay 8 minutes and 43 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants