Repository navigation
Highlight sidebar navigation tiles as the user scrolls the page manually - #180
Merged
Merged
Conversation
LAKSHMIRPILLAI
changed the title
dblatcher
approved these changes
Aug 4, 2026
| href: string; | ||
| trackedSectionId: string; | ||
| isSelected: boolean; | ||
| onPress: () => void; |
Contributor
There was a problem hiding this comment.
Do we use the onPress property anymore? It looks like we could do without it.
Contributor
Author
There was a problem hiding this comment.
we need it in SideNavigationPanelTileProps, but I have removed it from SIDE_NAVIGATION_PANEL_ITEMS
| display: 'flex', | ||
| flexDirection: 'column', | ||
| gap: semanticSpacing.stackLg, | ||
| width: '476px', |
Contributor
There was a problem hiding this comment.
We don't need to address this now, but having the width set here might make it difficult to implement the layout for different breakpoints when we get to that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Highlighted tile should change as the user scrolls the page manually
Note
This also solves the issue of click action and scrolling competing to set the selected href for highlighting the side navigation tile to an extend
How has this change been tested?
Tested locally
How can we measure success?
On user scrolling through the page, the relevant side bar navigation tile should be highlighted
Have we considered potential risks?
Not too risky as not in production yet