-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix husky pre-commit
hook
#314
Conversation
1ec8fe9
to
b081524
Compare
b081524
to
7b16d1e
Compare
the code looks good to me but I haven't been able to trigger the hook itself...
Am I missing a step to get the hooks set up? |
its a pre-commit hook, so shouldn't need the git push (basically the commit should be slow), not sure why it's not running for you though, will message you offline... |
…executing the various steps in the `pre-commit` hook (configured via husky)
7b16d1e
to
ed944f6
Compare
…l dependencies get installed
@bryophyta I can't seem to think why the hook wasn't running for you. I've just updated the If that doesn't work, perhaps you might try https://typicode.github.io/husky/troubleshoot.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Seen on PROD (merged by @twrichards 3 minutes and 14 seconds ago) Please check your changes! |
run
fnm use
andnvm use
to ensure correct version of node before executing the various steps in thepre-commit
hook (configured via husky)Broken since #307