add JS cookies info to diagnostics #6491
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnduffell
commented
Nov 7, 2024
| val cookiesJS = | ||
| "<pre><script>document.write(document.cookie.split('; ').map((a) => a.split('=')).map((a) => a[0] + ' ' + a[1]?.length).join('\\n'))</script></pre>" | ||
| Html( | ||
| s"<html><body><h2>HTTP cookies</h2><pre>$body</pre><h2>JS cookie keys and lengths</h2>$cookiesJS</body></html>", |
There was a problem hiding this comment.
I'm relying on body and cookiesJS not needing any escaping here
There was a problem hiding this comment.
the proper way would be to add a twirl template and let it handle the escaping
|
Size Change: 0 B Total Size: 2.29 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it would be useful to have a guide as to whether JS can get hold of cookies on the client side when users are having trouble
This PR adds these to the https://support.theguardian.com/cookies endpoint at the bottom
The JS is super hacky but it just about does the job. But improvements appreciated in case I've missed something (tested in latest chrome on desktop only)