Refactor country group switcher to CSS in JS #6645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .component-country-group-switcher { | ||
| display: inline-flex; | ||
|
|
||
| .component-select-input__select { |
There was a problem hiding this comment.
I could not find this used anywhere, so I did not recreate in emotion
| color: inherit; | ||
| cursor: pointer; | ||
| color: ${palette.neutral[100]}; | ||
| ${textSans17}; |
There was a problem hiding this comment.
The previous version was size 16, this doesn't exist in source so I went with 17px
|
Size Change: +4.72 kB (+0.21%) Total Size: 2.24 MB
ℹ️ View Unchanged
|
rupertbates
approved these changes
Dec 19, 2024
| open ? 'open' : null, | ||
| styled ? 'styled' : null, | ||
| ])} | ||
| css={[dialog, open && openCss, styled && styledCss]} |
There was a problem hiding this comment.
Havent used that method before, saves passing the parameter in side the css, great
|
Seen on PROD (merged by @andrewHEguardian 10 minutes and 7 seconds ago)
Sentry Release: support-client-side, support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you doing in this PR?
Refactor the country group switcher and its subcomponents from scss to emotion.
Trello Card
Why are you doing this?
We no longer use sass in this project.
How to test
Go to https://support.thegulocal.com/uk/contribute and click on the country drop down. Also https://support.thegulocal.com/uk/subscribe/weekly. Test the hover states, and closing and opening the dialog.
Screenshots
Before (3 tier landing)
After
Before (subscription landing)
After
