Remove redundant price check #2011
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonflynng
commented
Jun 30, 2023
| @@ -56,14 +56,6 @@ object ToRecurringContribution { | |||
| ) | |||
| (activeRatePlan, activeRatePlanCharge) = activeRatePlanAndCharge | |||
|
|
|||
| currency <- ZIO | |||
There was a problem hiding this comment.
currency was not being used
shtukas
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are calculating the amount the user is currently paying on the server-side but it is also being passed in as the
priceproperty from the frontend. This removes the calculation and just uses the property passed from the frontend.