Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the snapshots #2197

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update the snapshots #2197

wants to merge 3 commits into from

Conversation

LAKSHMIRPILLAI
Copy link
Contributor

@LAKSHMIRPILLAI LAKSHMIRPILLAI commented Mar 21, 2024

What does this change?

This is to update the cdk snapshots

This is because on merging the PR Recreate existing CFN template using CDK constructs for stripe-webhook-endpoints. the following jobs failed

image

CI-Typescript

image

CI-Scala

image

@LAKSHMIRPILLAI LAKSHMIRPILLAI marked this pull request as ready for review March 21, 2024 11:11
@@ -43,7 +43,7 @@ export class StripeWebhookEndpoints extends GuStack {
functionName: `stripe-payment-intent-issues-cdk-${this.stage}`,
fileName: `${app}.jar`,
handler: "com.gu.paymentIntentIssues.Lambda::handler",
runtime: Runtime.JAVA_11,
runtime: Runtime.JAVA_21,
Copy link
Member

@tomrf1 tomrf1 Mar 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes it consistent with the recent change to the legacy cfn.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants