You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, device rotation is locked into portrait for phones and tablets are locked into either portait or landscape, depending on the position upon startup. This new preference allows device rotation for all devices when enabled.
Currently, device rotation is locked into portrait for phones
and tablets are locked into either portait or landscape, depending
on the position upon startup. This new preference allows device
rotation for all devices when enabled.
I don't really get why we should turn this into a pref. Locking the orientation is bad UX, we should focus on the underlying issue that caused the orientation to not work properly in the first place.
I don't really get why we should turn this into a pref. Locking the orientation is bad UX, we should focus on the underlying issue that caused the orientation to not work properly in the first place.
I agree that we should also determine the cause of these rotation problems, but this still seems like it could be a preference. Maybe some users want the rotation locked. In the meantime, the rotation issues will never get fixed if it is always locked and can't be tested by users.
I don't really get why we should turn this into a pref. Locking the orientation is bad UX, we should focus on the underlying issue that caused the orientation to not work properly in the first place.
I agree that we should also determine the cause of these rotation problems, but this still seems like it could be a preference. Maybe some users want the rotation locked. In the meantime, the rotation issues will never get fixed if it is always locked and can't be tested by users.
Ok seems like a good starting point to me. It also makes testing rotation on the emulator easier. And when the rotation issues are fixed, we can get rid of the pref.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
syphyr
force-pushed
the
device_rotation
branch
from
Currently, device rotation is locked into portrait for phones and tablets are locked into either portait or landscape, depending on the position upon startup. This new preference allows device rotation for all devices when enabled.