Fix support for Snowflake Amp #1248
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snowflake brokers should only set fingerprint and utls-imitate in order to support both snowflake and snowflake-amp. The rest of the IPtProxy settings for snowflake and snowflake-amp are done within the OrbotService with mIptProxy.set*.
syphyr
force-pushed
the
fix_snowflake_amp
branch
from
1704882 to
ce84e3a
Compare
|
Snowflake brokers should only set fingerprint and utls-imitate in order to support both snowflake and snowflake-amp. The rest of the IPtProxy settings for snowflake and snowflake-amp are done within the OrbotService with mIptProxy.set*. |
|
This PR also fixes a bug where the snowflake client settings are being set twice. Once in OrbotService and once within the snowflake-broker file. The snowflake and snowflake-amp client specific settings should only be set by mIptProxy.set*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes support for Snowflake Amp.