Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Nest Audio" device #99

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Molkobain
Copy link
Contributor

Objective
This PR adds the "Nest Audio" device to the GCast devices list so its picture can be displayed correctly.

Current behavior
As you can see below, currently it displays the default model picture:
image

Expected behavior
Here is the result with the device correctly displayed
image

Cause
This is due to the model name being "Nest Audio"
image

Proposed solution
Unfortunately, unlike for "Google Nest Mini" or "Google Nest Hub", the device's model isn't prefixed with "Google " which makes it less homogenous. So I used the "real" model name in the GCAST_MODELS key but kept the picture name homogenous with the other Nest devices.

        'nest audio' =>
            array('logo' => 'model_googlenest_audio.png', 'ga' => true),

@Molkobain
Copy link
Contributor Author

Hello @guirem any update on the PR? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant