feat: favorite within post #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great thanks @coolsloth55. I think having an extra step to close for now is fine. Once commands are implemented then users can assign a custom keystroke to favourite and close but better to leave explicit for now. |
|
I'm happy to merge if you are, just change from draft. |
guyfedwards
force-pushed
the
feat/favorite-within-post
branch
from
e874e79 to
2fb11de
Compare
|
released in v2.7.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements first ideal in #75. Duplicated functionality across views but maybe it's desired. If not feel free to close 👍.
Only thing I could see different is possibly closing upon favoriting to save key stroke.