Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with numpy import in pycbc_coinc_findtrigs #4571

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Fix bug with numpy import in pycbc_coinc_findtrigs #4571

merged 1 commit into from
Nov 28, 2023

Conversation

ArthurTolley
Copy link
Contributor

Numpy is imported simply as import numpy in pycbc_coinc_findtrigs. There is a single call of np.array which will cause a name error:

NameError: name 'np' is not defined.

This is a simple fix to replace np.array with numpy.array.

@ArthurTolley ArthurTolley self-assigned this Nov 28, 2023
@ArthurTolley ArthurTolley enabled auto-merge (squash) November 28, 2023 11:34
GarethCabournDavies
GarethCabournDavies approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@GarethCabournDavies GarethCabournDavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I suppose we just never run without --randomize-template-order!

@ArthurTolley
Copy link
Contributor Author

Mustn't have done, I was using it too. I only noticed the bug from the VSCode line highlight! Thanks :)

@ArthurTolley ArthurTolley merged commit 992940c into gwastro:master Nov 28, 2023
31 checks passed
@ArthurTolley ArthurTolley deleted the import_bug branch November 28, 2023 13:32
maxtrevor pushed a commit to maxtrevor/pycbc that referenced this pull request Dec 11, 2023
@ArthurTolley @maxtrevor
correcting numpy call based on import (gwastro#4571)
1483e3d
bhooshan-gadre pushed a commit to bhooshan-gadre/pycbc that referenced this pull request Dec 19, 2023
@ArthurTolley @bhooshan-gadre
correcting numpy call based on import (gwastro#4571)
11b28de
bhooshan-gadre pushed a commit to bhooshan-gadre/pycbc that referenced this pull request Mar 4, 2024
@ArthurTolley @bhooshan-gadre
correcting numpy call based on import (gwastro#4571)
e34cc3d
lpathak97 pushed a commit to lpathak97/pycbc that referenced this pull request Mar 13, 2024
@ArthurTolley @lpathak97
correcting numpy call based on import (gwastro#4571)
0758b88
acorreia61201 pushed a commit to acorreia61201/pycbc that referenced this pull request Apr 4, 2024
@ArthurTolley @acorreia61201
correcting numpy call based on import (gwastro#4571)
1734b23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarethCabournDavies GarethCabournDavies GarethCabournDavies approved these changes

Assignees

@ArthurTolley ArthurTolley

Labels
bug offline search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArthurTolley @GarethCabournDavies @tdent